Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2925]: USDC market deployments on zksync #452

Merged
merged 4 commits into from
Nov 6, 2024
Merged

[VEN-2925]: USDC market deployments on zksync #452

merged 4 commits into from
Nov 6, 2024

Conversation

GitGuru7
Copy link
Contributor

@GitGuru7 GitGuru7 commented Nov 4, 2024

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 requested a review from chechu November 4, 2024 13:46
@GitGuru7 GitGuru7 self-assigned this Nov 4, 2024
chechu
chechu reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sepolia files lgtm

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Package Line Rate Branch Rate Health
contracts 94% 76% ✔
contracts.Gateway 98% 68% ✔
contracts.Gateway.Interfaces 100% 100% ✔
contracts.Lens 95% 71% ✔
contracts.Lens.legacy 0% 0% ❌
contracts.Pool 100% 92% ✔
contracts.Rewards 96% 70% ✔
contracts.Shortfall 100% 85% ✔
contracts.legacy.RiskFund 0% 0% ❌
contracts.lib 100% 89% ✔
Summary 76% (1557 / 2055) 65% (516 / 798) ➖

@chechu chechu merged commit fbdf778 into develop Nov 6, 2024
4 checks passed
@chechu chechu mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web3rover web3rover web3rover approved these changes

@chechu chechu chechu approved these changes

Assignees

@GitGuru7 GitGuru7

Labels
zkSync sepolia zkSync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GitGuru7 @chechu @web3rover